Repository navigation
Replace CCShareable with shared pointers - #138
Merged
Merged
Conversation
dgirardeau
force-pushed
the
dgirardeau-replace-ccshareable
branch
2 times, most recently
from
September 27, 2026 21:57
ff68eb8 to
738ffb1
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
dgirardeau
force-pushed
the
dgirardeau-replace-ccshareable
branch
from
September 27, 2026 22:41
738ffb1 to
9b89f58
Compare
rjanvier
approved these changes
Sep 28, 2026
rjanvier
approved these changes
Sep 28, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public borrowed-pointer compatibility, header completeness, and virtual destruction issues remain unresolved.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
Replaces intrusive CCShareable scalar-field ownership with std::shared_ptr across point clouds and processing tools.
Changes:
- Migrates scalar-field storage and temporary allocations to shared pointers.
- Updates registration and distance-field interfaces.
- Removes obsolete
CCShareableand garbage-management infrastructure.
| File | Description |
|---|---|
src/ScalarFieldTools.cpp |
Uses shared gradient storage. |
src/RegistrationTools.cpp |
Migrates temporary scalar fields. |
src/CMakeLists.txt |
Removes obsolete source registration. |
src/CCShareable.cpp |
Removes obsolete implementation. |
src/AutoSegmentationTools.cpp |
Uses shared distance storage. |
include/ScalarField.h |
Defines shared ownership for scalar fields. |
include/RegistrationTools.h |
Updates registration weight fields. |
include/PointCloudTpl.h |
Stores scalar fields using shared pointers. |
include/Garbage.h |
Removes scalar-field garbage specialization. |
include/DistanceComputationTools.h |
Updates split-distance fields. |
include/CMakeLists.txt |
Removes obsolete header installation. |
include/CCShareable.h |
Removes obsolete interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the intrusive
CCShareablereference-counting model with standardstd::shared_ptrownership for scalar fields.PointCloudTplnow shares scalar fields throughstd::shared_ptr, and temporary scalar fields in registration and processing tools usestd::make_shared. Borrowed raw pointers remain at algorithm boundaries, preserving the existing public call patterns. The obsolete scalar-field garbage specialization andCCShareablesources/install entries are removed.Validation: clean CMake Release build with MSVC, with Qt Concurrent and CGAL disabled.