You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[client-v2] Build the User-Agent in the standard client format and let applications add metadata #3202
client-v2 always appends its own part to the application's client name (HttpAPIClientHelper#buildDefaultUserAgent / #correctUserAgentHeader, same in 0.9.5 and 0.11.0-rc1):
Send the language version as lv:java/<java.version> instead of jvm:, and the OS as os:<os.name> instead of a plain comment.
Don't append Apache-HttpClient/<v> after the bracket group (drop it or move it into a key).
Let applications add key/value pairs to the client's bracket group, e.g. Client.Builder#setClientMetadata(Map<String, String>). Today a connector has to add its own bracket group before clickhouse-java-v2/<v>, so it can't follow the format.
Example (Flink connector)
Now: Flink-ClickHouse-Sink/0.2.0 (fv:flink/2.0.0; api:table) clickhouse-java-v2/0.9.5 (Mac OS X; jvm:17.0.19) Apache-HttpClient/5.4.4
Expected: Flink-ClickHouse-Sink/0.2.0 clickhouse-java-v2/0.11.0 (fv:flink/2.0.0; api:table; lv:java/17.0.19; os:Mac OS X)
This affects every Java-based connector that sets a client name (Flink, Spark, Kafka Connect).
Activity
[client-v2] Move client identification into WorkloadIdentitySupport
[client-v2] Compose the User-Agent client part in one method