Repository navigation
web: turn manifest page into processConfidentialTransaction runner - #35
Merged
Merged
Conversation
Select a JSON file or paste the request JSON, validate it with parseLiquidProcessCtParams, and send it via wallet.processConfidentialTransaction. Removes the manifest inspector modules and the now-unused @humid/smplx-compiler dependency.
Replace the request-triggered unlock bridge with a confirmation queue. The background responder now runs on @tanstack/pacer AsyncQueuer (one confirmation at a time, per-request deferreds, MetaMask ApprovalController style) and reuses the notification window until the queue is idle. Closing the window rejects queued and active confirmations. Requests that need the wallet while it is locked (injected connect/invoke/addChain/switchChain, WalletConnect proposals and requests) call waitForUnlock(): at most one priority unlock confirmation is queued and released by any vault unlock. The unlock confirmation defines its own five-minute timeout in wallet-vault/unlockConfirmation.ts and renders LocalAuthPage; dismissing it still rejects with 4900. Also simplify the earlier tester-feedback fixes: drop the shared unlock form, the custom Liquid signing renderer and connect requiresUnlock flag; show signing contents and requester through DefaultConfirmation; move PSET handling into signPset.ts as blindAndInspectPset with reviewedPset signing; let method confirmation policies set timeoutMs.
hotfix audited qa
lukachi
marked this pull request as ready for review
October 5, 2026 15:56
Arvolear
approved these changes
Oct 6, 2026
Arvolear
left a comment
Arvolear
left a comment
Member
There was a problem hiding this comment.
There are some minor text issues, but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select a JSON file or paste the request JSON, validate it with parseLiquidProcessCtParams, and send it via
wallet.processConfidentialTransaction. Removes the manifest inspector modules and the now-unused @humid/smplx-compiler dependency.