Repository navigation
Keep analyzing items after an undefined type - #430
Merged
LesterEvSe merged 2 commits intoOct 7, 2026
Merged
Conversation
LesterEvSe
force-pushed
the
feat/never-recovery
branch
from
September 29, 2026 15:20
38c6d9d to
7c93544
Compare
LesterEvSe
force-pushed
the
feat/never-recovery
branch
6 times, most recently
from
October 2, 2026 12:54
6783642 to
9518bde
Compare
Collaborator
There was a problem hiding this comment.
in 9518bde
This is pretty difficult to review, can we simplify the logic?
This is clearly vibe coded but is missing the Assisted-by: Claude commit footer
Collaborator
Author
|
The main difficulty in this PR comes from using the Some of the problems were:
So I plan to research it more, and then fix and split it into several commits to make it easier to review. |
LesterEvSe
force-pushed
the
feat/never-recovery
branch
3 times, most recently
from
October 6, 2026 13:34
17bd576 to
1858728
Compare
LesterEvSe
force-pushed
the
feat/never-recovery
branch
from
October 6, 2026 14:19
1858728 to
a76b9f7
Compare
LesterEvSe
force-pushed
the
feat/never-recovery
branch
from
October 7, 2026 09:38
a76b9f7 to
81da432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An undefined type in a function signature, type alias or enum payload no longer stops the analysis. It is replaced with
!, which matches every type, so only the undefined name is reported and its uses are not.For this code:
On master there is only one error:
With this PR:
Limitations
These will be handled in later PRs:
fn f(a: Missing),let x: u32 = f(1);fails without a new error, and the statements after it in the same block are not analyzed. Other items still are.let x: Missing = ...stops its block.let x: Alias = ...already works whenAliasis broken.usestill stops the analysis.