Repository navigation
docs: Drop raw alignment benchmark data - #143
BenWestgate wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86c0d496c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
86c0d49 to
e976c8c
Compare
e976c8c to
fc31559
Compare
The per-case CSV and kernel JSON (~9,900 lines) are generated records of an interrupted run that promoted no timing guarantee, and nothing in the package, tests or tools reads them. Keep the summary in alignment-benchmarks.md as informational guidance for setting correction limits on slower devices, drop its run-condition and source-hash details, point to the history for the raw JSON, and stop shipping docs *.csv/*.json in the sdist. Claude-Session: https://claude.ai/code/session_01MDsbGqZmvVThoJrs4vzc4K
fc31559 to
667b5ee
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head docs review: ACK 667b5ee. The raw benchmark files leave the release package; the summary retains measured scope, incomplete cases, and the historical data commit. Reproduction commands are correctly described as emitting new JSONL, not recreating deleted CSV/JSON files.
Requested by Ben · project thread
Before: the repo carries
docs/developer/alignment-kernel-benchmarks.jsonandalignment-public-benchmarks.csv, about 9,900 lines of generated benchmark records.alignment-benchmarks.mddescribes CPU quotas, reboots and source hashes from that run.After: both files are removed.
alignment-benchmarks.mdis framed as informational guidance for setting correction limits on slower devices. It keeps the summary tables, drops the run-condition, CSV and source-hash details, and points to the raw JSON in history at753cf61. The sdist no longer shipsdocs/*.csvordocs/*.json.Nothing in the package, tests or tools reads these files.
How: delete the two files, trim the doc, and trim
MANIFEST.in. Docs and packaging only, with no code change.#142 will be rebuilt to match this change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MDsbGqZmvVThoJrs4vzc4K