Skip to content

docs: Drop raw alignment benchmark data - #143

Open
BenWestgate wants to merge 1 commit into
reviewability-v1from
claude/drop-benchmark-data
Open

BenWestgate wants to merge 1 commit into
reviewability-v1from
claude/drop-benchmark-data

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Requested by Ben · project thread

Before: the repo carries docs/developer/alignment-kernel-benchmarks.json and alignment-public-benchmarks.csv, about 9,900 lines of generated benchmark records. alignment-benchmarks.md describes CPU quotas, reboots and source hashes from that run.

After: both files are removed. alignment-benchmarks.md is framed as informational guidance for setting correction limits on slower devices. It keeps the summary tables, drops the run-condition, CSV and source-hash details, and points to the raw JSON in history at 753cf61. The sdist no longer ships docs/*.csv or docs/*.json.

Nothing in the package, tests or tools reads these files.

How: delete the two files, trim the doc, and trim MANIFEST.in. Docs and packaging only, with no code change.

#142 will be rebuilt to match this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MDsbGqZmvVThoJrs4vzc4K

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T19:08:41.070795Z 667b5ee New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BenWestgate BenWestgate self-assigned this Oct 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86c0d496c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/developer/alignment-benchmarks.md Outdated
The per-case CSV and kernel JSON (~9,900 lines) are generated records of
an interrupted run that promoted no timing guarantee, and nothing in the
package, tests or tools reads them. Keep the summary in
alignment-benchmarks.md as informational guidance for setting correction
limits on slower devices, drop its run-condition and source-hash details,
point to the history for the raw JSON, and stop shipping docs
*.csv/*.json in the sdist.

Claude-Session: https://claude.ai/code/session_01MDsbGqZmvVThoJrs4vzc4K
@BenWestgate
BenWestgate force-pushed the claude/drop-benchmark-data branch from fc31559 to 667b5ee Compare October 9, 2026 19:07

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head docs review: ACK 667b5ee. The raw benchmark files leave the release package; the summary retains measured scope, incomplete cases, and the historical data commit. Reproduction commands are correctly described as emitting new JSONL, not recreating deleted CSV/JSON files.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant