Repository navigation
Restore upstream license headers; document the fingerprint argument - #138
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BenWestgate
force-pushed
the
claude/remove-unused-api
branch
from
October 8, 2026 01:51
0c5d3f0 to
c8bedfd
Compare
BenWestgate
force-pushed
the
claude/v1-review-notices
branch
from
October 8, 2026 01:56
a7969dc to
ae6a5ca
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae6a5ca912
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The v1 rewrite dropped the license headers that master carries in bech32.py and checksums.py. bech32.py still derives convertbits from Pieter Wuille's segwit_addr.py, and checksums.py keeps his polymod arithmetic and Leon Olsson Curr and Pearlwort Sneed's codex32 generators. MIT and BSD-3-Clause both require the notice to travel with the code, and CONTRIBUTING.md requires the original author's header on derived work. Restore master's headers, except that checksums.py now credits the polymod arithmetic, since it no longer holds Bech32/Bech32m constants. Each credit also names its upstream source, sipa/bech32's ref/python/segwit_addr.py or BIP-93, as CONTRIBUTING.md asks. Comments do not count toward the package line budget. Claude-Session: https://claude.ai/code/session_01T233rKgZqE5wzDm3EVTHL1
The one-shot signature in api.md omitted generate_master_seed's fingerprint argument. A fresh call that leaves identifier unset raises ValueError unless that callable is supplied, so the documented defaults could not generate a seed. Show the argument and its contract. Claude-Session: https://claude.ai/code/session_01T233rKgZqE5wzDm3EVTHL1
BenWestgate
force-pushed
the
claude/v1-review-notices
branch
from
October 8, 2026 02:00
ae6a5ca to
85119a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: v1's
bech32.pyandchecksums.pyhad lost the license headers that master carries. Those headers credit Pieter Wuille (MIT) and Leon Olsson Curr and Pearlwort Sneed (BSD-3-Clause), whose code those files still derive from. Separately,api.mdshowedgenerate_master_seedwithout itsfingerprintargument, which a fresh call needs unlessidentifieris set.After: both files carry master's headers again, each credit naming its upstream source, and
api.mddocumentsfingerprint.checksums.pynow credits the polymod arithmetic instead of Bech32/Bech32m constants, because it no longer holds those constants. Each credit also names its source (sipa/bech32'sref/python/segwit_addr.py, or BIP-93), since CONTRIBUTING.md requires derived work to carry the original author's header with its source, and both licenses require the notice to ship with the code. Comments don't count toward the line budget.fingerprint=Noneto the signature. It says the argument is a callable that returns the seed's four-byte BIP32 fingerprint, that this package has no secp256k1 arithmetic so the CLI gets it from Bitcoin Core, and that a fresh call with neitherfingerprintnoridentifierraisesValueError.Both come from Codex's latest review of #94. Its fourth finding there,
core_descriptorsignoring the seed, is already fixed by #130. This PR is stacked on #130 because both touch the same lines ofchecksums.pyandapi.md. The full suite passes (907 tests), and ruff is clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01T233rKgZqE5wzDm3EVTHL1