Repository navigation
feat: implement exact seeded base-pair probabilities (#257) - #258
Open
Alexander-Mitrofanov wants to merge 8 commits into
Open
Alexander-Mitrofanov wants to merge 8 commits into
Alexander-Mitrofanov wants to merge 8 commits into
Conversation
Member
|
thanks, implement the plan in multiple commits (at least one per step) to this branch |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact seeded
--model=P --mode=Mprediction now counts each complete interaction once, even when it contains several overlapping or disjoint seeds.--out=bpProb:FILEreports actual interior-pair probabilities over the union of searched disjoint regions, using the same raw partition denominator as prediction without pair output.The implementation follows the reviewed plan on this existing branch in seven separate commits, one per step:
88f4369: Establish an independent exhaustive weighted-chain oracle and all ten unrounded theory fixtures.62afc24: Compile geometric stack-seed capability, active occurrences, and eligible domains.5c8907c: Validate and compare both kernel candidates and select the suffix kernel.8bd8534: Integrate unique partition accounting, shared boundary coefficients, extension hooks, and exact-zero handling.99919de: Accumulate raw pair masses in original coordinates across successful disjoint regions.3f6d3d1: Expose the matrix writer and CLI output, including multiFASTA, gzip, and shared streams.48efc54: Complete validation, documentation, performance measurements, installed consumer checks, and packaging.Stack-seed admission is preserved, including accepted mixed-length and singleton explicit seeds. Existing bulged and heuristic prediction paths remain available; unsupported combinations with
bpProbfail explicitly. The new matrix contains actual pairs; existing spot output retains its coverage interpretation. Successful empty searches produceNAentries. Numerical range errors fail explicitly without a scaling fallback, and failed calculations do not publish a partial probability matrix. Corrected partition accounting can change ensemble results; no golden output was regenerated to conceal differences.Validation:
-leasyloggingdependency is fixed and CI now runs this consumer.make distsucceeds and includes all 23 new distributable files. Encoding andgit diff --checkpass.See kernel comparison and validation report for reproducible commands and limitations. Apple Clang validation is left to the existing macOS CI because that toolchain is unavailable locally.
Addresses #257.