Repository navigation
Fix regional overlap validation and suboptimal output filtering - #253
Merged
Merged
Conversation
Member
|
thanks, please revise: the following sections refer to "doc/analysis/out-overlap.md" of the "docs/212-overlap-analysis" branch. implement the sections as individual steps and commits to allow for individual review later on. suboptimal documentation
Concerning 1 Regional merging permits forbidden overlaps
Concerning 3 Later ensemble results use the wrong energyfix the bug and check if this fixes "2 Exhausted ensemble enumeration converts infinity to an integer" as proposed Concerning 4 Later heuristic results bypass terminal pair filteringfix the problem with missing internal output checks Concerning 5 Energy windows are local to regionsif "outPerRegion=false": implement a global min energy delta check within merging regions if this solves the issue Concerning 6 A valid right extension can be discarded before selectionkeep the current strategy and (if needed) slightly extend the README documentation concering this issue. |
martin-raden
marked this pull request as ready for review
October 5, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricted output could reuse forbidden positions across regions, omit accessibility penalties from later ensemble results, bypass output filters, or report results outside the sequence pair's energy window. This implements Martin's review of the issue #212 analysis in separate commits.
The regional checks resolve apparent shorthand typos using existing overlap semantics: N requires one region on both RNAs, T one target region, Q one query region, and B allows multiple regions. Multiple target regions can reuse the query, making them unsafe for T; the converse applies to Q. Ensemble restricted selection uses the base predictor's deterministic tie order; the other specialized selectors retain their scan order.
Reviewable commits
Validation
Addresses #212 and Martin's review. The existing completeness limitation is retained as requested; fewer compatible alternatives than requested can still be reported.