[PWGLF] Added unfolding process and modified MC inv mass process by JimunLee · Pull Request #18288 · AliceO2Group/O2Physics

JimunLee · 2026-10-14T10:56:06Z

Dear experts,

I've added histograms for the unfolding procedure and modified invariant mass reconstruction part in the MC process.
And I also changed the code name from "kstarInOO.cxx" to "kstarInJets.cxx"

Best regards,
Jimun

github-actions · 2026-10-14T11:06:30Z

O2 linter results: ❌ 0 errors, ⚠️ 138 warnings, 🔕 0 disabled

alibuild · 2026-10-14T16:08:43Z

Error while checking build/O2Physics/code-check for 41cd780 at 2026-10-14 18:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 4 warnings.'
Found 8 errors and 4 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/792bba6f535c9a31339e779ee8bc815cf06a551f/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:31:1: error: included header AnalysisHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:33:1: error: included header BinningPolicy.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:35:1: error: included header GroupedCombinations.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:54:1: error: included header unordered_set is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:1942:16: error: Value stored to 'dR' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:1942:16: error: unused variable 'dR' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:2094:68: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:2095:20: error: no header providing "rand_r" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/792bba6f535c9a31339e779ee8bc815cf06a551f/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:654:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:683:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInJets.cxx:712:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:742:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 8 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-10-14T16:11:51Z

Error while checking build/O2Physics/staging for 41cd780 at 2026-10-14 18:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInJets.cxx:1942:16: error: unused variable 'dR' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-10-14T16:13:19Z

Error while checking build/O2Physics/o2 for 41cd780 at 2026-10-14 18:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/kstarInJets.cxx:1942:16: error: unused variable 'dR' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-10-14T23:55:01Z

Converting to draft because of compilation errors.

alibuild · 2026-10-15T17:27:03Z

Error while checking build/O2Physics/code-check for 601f047 at 2026-10-15 19:27:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 4 warnings.'
Found 6 errors and 4 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/7288a3c7e3875a740b1259720a6f81988fbc672c/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:31:1: error: included header AnalysisHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:33:1: error: included header BinningPolicy.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:35:1: error: included header GroupedCombinations.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:54:1: error: included header unordered_set is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:2094:68: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:2095:20: error: no header providing "rand_r" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/7288a3c7e3875a740b1259720a6f81988fbc672c/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:654:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:683:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInJets.cxx:712:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:742:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera · 2026-10-15T19:02:16Z

@JimunLee Please fix the errors. Your task has wrong includes.

JimunLee · 2026-10-16T01:35:52Z

@JimunLee Please fix the errors. Your task has wrong includes.

Thanks a lot!
I checked and fixed the generated errors

alibuild · 2026-10-16T01:58:07Z

Error while checking build/O2Physics/code-check for 10d1c9a at 2026-10-16 03:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 4 warnings.'
Found 1 errors and 4 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/adb2a8a2203238b9efe5d674fe261da7608b2cf3/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:2092:20: error: no header providing "rand_r" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/adb2a8a2203238b9efe5d674fe261da7608b2cf3/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:651:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:680:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInJets.cxx:709:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:739:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-10-16T02:44:21Z

Error while checking build/O2Physics/code-check for b57c6a1 at 2026-10-16 04:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 4 warnings.'
Found 2 errors and 4 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/ec51d9962fdec463d888bc2fc6fe7d15f2f1d3d7/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:51:1: error: included header random is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/kstarInJets.cxx:2093:20: error: no header providing "rand_r" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/ec51d9962fdec463d888bc2fc6fe7d15f2f1d3d7/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/kstarInJets.cxx:652:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:681:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/kstarInJets.cxx:710:28: warning: redundant boolean literal in conditional assignment [readability-simplify-boolean-expr]
PWGLF/Tasks/Resonances/kstarInJets.cxx:740:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

alibuild · 2026-10-16T05:52:10Z

Error while checking build/O2Physics/o2 for e6e5920 at 2026-10-16 07:52:

No log files found

Full log here.

vkucera · 2026-10-16T12:58:30Z

@JimunLee Please fix the errors. Your task has wrong includes.

Thanks a lot! I checked and fixed the generated errors

Hi @JimunLee , thanks a lot for fixing the errors. If you feel like improving your code a bit further, you can have a look at the warnings as well and consider addressing them in your future PRs.

JimunLee · 2026-10-17T05:54:25Z

@JimunLee Please fix the errors. Your task has wrong includes.

Thanks a lot! I checked and fixed the generated errors

Hi @JimunLee , thanks a lot for fixing the errors. If you feel like improving your code a bit further, you can have a look at the warnings as well and consider addressing them in your future PRs.

@vkucera , You're right. I'll keep working on fixing and improving the code. Thanks a lot for your helpful advice!

Best regards,
Jimun

jimun_lee and others added 30 commits May 24, 2026 20:32

update of kstarInOO.cxx

80b77c1

update of kstarInOO.cxx

40fe710

update of dR

53d005c

update of dR

4a4ccba

update of dR

7f7d45b

update of dR

8cdd351

update of dR

181ff1e

update of dR

defb0d0

update of dR

980a8c9

update of dR

0d483e9

update of dR

2f8682c

[PWGLF] Added the option of cfgJetdR

1034dba

[PWGLF] Added the option of cfgJetdR

bc1d916

[PWGLF] Added the option of cfgJetdR

ff269f6

Merge branch 'master' into master

0ee2403

[PWGLF] Added the option of cfgJetdR

3ffdc5b

[PWGLF] Added also the option of cfgJetMaxEta

173b3e8

[PWGLF] Added also the option of cfgJetMaxEta

23f183b

[PWGLF] Fixed std::cout --> LOG(info) also

42673ca

[PWGLF] Fixed std::cout --> LOG(info) also

be153d8

[PWGLF] Fixed std::cout --> LOG(info) also

0cb0676

[PWGLF] Fixed std::cout --> LOG(info) also

bc4a015

[PWGLF] Fixed std::cout --> LOG(info) also

52ae7f4

[PWGLF] Added the Mis-IDentified PID cut

359c329

[PWGLF] Added the Mis-IDentified PID cut

363d647

Merge branch 'master' into master

c95ce6b

Merge branch 'AliceO2Group:master' into master

3661135

Merge branch 'AliceO2Group:master' into master

571352b

added isMIDDaughters function

53a2209

added isMIDDaughters function

1a29237

Added unfolding process and modified MC inv mass process

bcfe337

JimunLee closed this Oct 14, 2026

JimunLee reopened this Oct 14, 2026

Merge branch 'master' into master

8750538

Remove old kstarInOO task

41cd780

vkucera marked this pull request as draft October 14, 2026 23:55

Remove old kstarInOO task

601f047

JimunLee marked this pull request as ready for review October 15, 2026 09:23

Fixed the generated errors

10d1c9a

jimun_lee added 3 commits October 16, 2026 11:01

Fixed the generated errors

31b0639

Fixed the generated errors

2955a6c

Fixed the generated errors

b57c6a1

JimunLee marked this pull request as draft October 16, 2026 03:04

Fix rand_r header

d691a05

alibuild mentioned this pull request Oct 16, 2026

Please consider the following formatting changes to #18288 JimunLee/O2Physics#28

Closed

Fix rand_r header

e6e5920

JimunLee marked this pull request as ready for review October 16, 2026 05:37

Navigation Menu

Repository navigation

[PWGLF] Added unfolding process and modified MC inv mass process - #18288

[PWGLF] Added unfolding process and modified MC inv mass process#18288
JimunLee wants to merge 53 commits into
AliceO2Group:masterfrom
JimunLee:master

JimunLee commented Oct 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

vkucera commented Oct 14, 2026

Uh oh!

alibuild commented Oct 15, 2026

Uh oh!

vkucera commented Oct 15, 2026

Uh oh!

JimunLee commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

vkucera commented Oct 16, 2026

Uh oh!

JimunLee commented Oct 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

JimunLee commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

alibuild commented Oct 14, 2026

Uh oh!

vkucera commented Oct 14, 2026

Uh oh!

alibuild commented Oct 15, 2026

Uh oh!

vkucera commented Oct 15, 2026

Uh oh!

JimunLee commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

alibuild commented Oct 16, 2026

Uh oh!

vkucera commented Oct 16, 2026

Uh oh!

JimunLee commented Oct 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

JimunLee commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading