Repository navigation
[PWGLF] eventShapeCoex: switch to histogram output of sub-event moment sums - #18230
Merged
abmodak merged 2 commits intoOct 9, 2026
Merged
Conversation
|
O2 linter results: ❌ 0 errors, |
c-andrei
marked this pull request as ready for review
October 9, 2026 06:17
c-andrei
requested review from
abmodak,
alibuild,
gbencedi,
mpuccio,
omvazque and
skundu692
as code owners
October 9, 2026 06:17
Collaborator
abmodak
previously approved these changes
Oct 9, 2026
abmodak
enabled auto-merge (squash)
October 9, 2026 09:38
auto-merge was automatically disabled
October 9, 2026 09:39
Head branch was pushed to by a user without write access
abmodak
approved these changes
Oct 9, 2026
Collaborator
|
@c-andrei This was the only file including |
Contributor
Author
|
Hi @vkucera. Sorry for this! The first version of the task was producing derived data that proved to be too large for the slim trains. I'm now testing the feasibility of switching to histograms but the conclusion is not final yet. Should I remove the .h file now (in the next PR) or wait until I reach a final conclusion? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the derived tables (too large for slim trains) with histogram output.