Skip to content

[PWGDQ] update dqeff direct - #18191

Merged
XiaozhiBai merged 1 commit into
AliceO2Group:masterfrom
ypwangg:Psi2S-dqeff-PR
Oct 8, 2026
Merged

XiaozhiBai merged 1 commit into
AliceO2Group:masterfrom
ypwangg:Psi2S-dqeff-PR

Conversation

@ypwangg

@ypwangg ypwangg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgdq label Oct 6, 2026
@github-actions github-actions Bot changed the title update dqeff direct [PWGDQ] update dqeff direct Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1192 warnings, 🔕 91 disabled

@alibuild

alibuild commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 08197e0 at 2026-10-08 10:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 31 warnings.'
Found 1 errors and 31 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/d86a68da8c274a3c2bd12a6b55e57cff410b83de/O2Physics-code-check/errors.txt
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3452:15: error: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]
++ [[ 31 -gt 0 ]]
++ cat /sw/BUILD/d86a68da8c274a3c2bd12a6b55e57cff410b83de/O2Physics-code-check/warnings.txt
PWGDQ/Core/CutsLibrary.cxx:3663:8: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
PWGDQ/Core/CutsLibrary.cxx:3663:8: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGDQ/Core/CutsLibrary.cxx:7134:8: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
PWGDQ/Core/CutsLibrary.cxx:7134:8: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGDQ/Core/CutsLibrary.cxx:7601:33: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7631:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7638:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7649:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:8002:21: warning: redundant string initialization [readability-redundant-string-init]
PWGDQ/Core/CutsLibrary.cxx:8078:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
PWGDQ/Core/CutsLibrary.h:122:23: warning: function 'o2::aod::dqcuts::ParseJSONAnalysisCompositeCut' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/CutsLibrary.h:152:37: warning: function 'o2::aod::dqmlcuts::makeLabeledCutsMl' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/VarManager.h:1238:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1239:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1655:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1659:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:4591:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5255:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5258:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5259:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3192:8: warning: constructor does not initialize these fields: fCurrentRun, fTrackCutBitMap1, fTrackCutBitMap2, fCCDB, fValuesQuadruplet, fHistMan [cppcoreguidelines-pro-type-member-init]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3269:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3289:34: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3289:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3412:7: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3449:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3481:55: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3573:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3575:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3677:98: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/dqEfficiency_withAssoc_direct.cxx:3684:74: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@XiaozhiBai
XiaozhiBai enabled auto-merge (squash) October 8, 2026 02:46
@XiaozhiBai
XiaozhiBai merged commit 259515a into AliceO2Group:master Oct 8, 2026
13 of 15 checks passed
@ypwangg
ypwangg deleted the Psi2S-dqeff-PR branch October 8, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants