[PWGJE] jetChargedV2 task: unify in-/out-of-plane selection for jet pT and background fluctuations - #18183
Merged
Conversation
YubiaoWang
commented
Oct 5, 2026
YubiaoWang
commented
Contributor
- Jet pT and background fluctuations now use the same event-plane definition: Δφ = φ − Ψ₂(FT0C, corrected Q-vector) in [0, 2π), with the same three-window in-/out-of-plane selection.
- The folded 0–π version moved for QC.
- Fixed Fluctuation histograms centrality region, and direct h2 in-/out-of-plane histograms are now provided for both the median_rho and the local_rho variants.
YubiaoWang
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
October 5, 2026 21:48
|
O2 linter results: ❌ 0 errors, |
nzardosh
requested changes
Oct 6, 2026
| } | ||
| } | ||
| phi = RecoDecay::constrainAngle(phi, 0.); | ||
| return fitFunc->Integral(phi - radius, phi + radius); |
Collaborator
There was a problem hiding this comment.
shouldn't phi-radius and phi+radius also be wrapped in 0-2pi as well?
Contributor
Author
There was a problem hiding this comment.
Hello Nima,
Thanks for comments. This update is keeping the integration limits within [0, 2π) by splitting the interval into two pieces when it crosses 0 or 2π. For the 2π-periodic fit function, the result is unchanged.
Collaborator
|
Can you instead not just use recodecay::ConstrainAngle for phi - radius and phi + radius? |
nzardosh
self-requested a review
October 6, 2026 10:57
nzardosh
approved these changes
Oct 6, 2026
nzardosh
enabled auto-merge (squash)
October 6, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.