Skip to content

[Common et all] Fix cpplint errors - #18106

Open
vkucera wants to merge 6 commits into
AliceO2Group:masterfrom
vkucera:cpplint
Open

[Common et all] Fix cpplint errors#18106
vkucera wants to merge 6 commits into
AliceO2Group:masterfrom
vkucera:cpplint

Conversation

@vkucera

@vkucera vkucera commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes errors from the following categories:

  • runtime/string
  • runtime/int
  • runtime/explicit
  • runtime/arrays

NB: Cannot be split per directory because of cross-dependencies.

@github-actions

github-actions Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2830 warnings, 🔕 9 disabled

@github-actions github-actions Bot changed the title Fix cpplint errors [Common,DPG,Tutorial,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGMM,PWGUD] Fix cpplint errors Sep 29, 2026
@vkucera vkucera changed the title [Common,DPG,Tutorial,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGMM,PWGUD] Fix cpplint errors [Common et al.] Fix cpplint errors Sep 29, 2026
@github-actions github-actions Bot changed the title [Common et al.] Fix cpplint errors [Common,DPG,Tutorial,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGMM,PWGUD] [Common et al.] Fix cpplint errors Sep 29, 2026
@vkucera vkucera changed the title [Common,DPG,Tutorial,ALICE3,PWGCF,PWGDQ,PWGEM,PWGHF,PWGJE,PWGLF,PWGMM,PWGUD] [Common et al.] Fix cpplint errors [Common et all] Fix cpplint errors Sep 30, 2026
@vkucera
vkucera marked this pull request as ready for review October 7, 2026 15:39
maciacco
maciacco previously approved these changes Oct 7, 2026
View reviewed changes
@vkucera

vkucera commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry @maciacco , I had to fix a new thing from upstream.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7ec92da at 2026-10-07 21:49:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 107 errors and 1256 warnings.'
Found 107 errors and 1256 warnings.
++ [[ 107 -gt 0 ]]
++ cat /sw/BUILD/75440396be3b5f524f20340284c9ca47cc3a2ee5/O2Physics-code-check/errors.txt
Common/CCDB/TriggerAliases.cxx:19:12: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/CCDB/TriggerAliases.h:54:19: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/CCDB/macros/upload_event_selection_params.C:37:8: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/CCDB/macros/upload_event_selection_params.C:259:35: error: format specifies type 'unsigned long long' but the argument has type 'long' [clang-diagnostic-format,-warnings-as-errors]
Common/CCDB/macros/upload_event_selection_params.C:259:40: error: format specifies type 'unsigned long long' but the argument has type 'long' [clang-diagnostic-format,-warnings-as-errors]
Common/Core/PID/TPCPIDResponse.h:80:46: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Core/TrackSelection.h:71:21: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tasks/flowTest.cxx:103:5: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
Common/Tools/Multiplicity/MultModule.h:483:10: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:115:3: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:633:7: error: Value stored to 'mixedNormError' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:67:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:79:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:96:103: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:98:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:102:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:104:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:109:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:110:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:111:96: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kAbsUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:117:104: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:5: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:32: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:59: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:86: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:139:31: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:178:9: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:185:5: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:198:7: error: no matching function for call to object of type 'Produces<aod::FemtoWorldParticles>' (aka 'Produces<Table<Hash<"FemtoWorldParticles"_h>, Hash<"FEMTOWORLDPARTS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:22:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:31:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:36:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:39:1: error: included header Vector4Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:40:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9e97971 at 2026-10-08 01:49:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 89 errors and 1256 warnings.'
Found 89 errors and 1256 warnings.
++ [[ 89 -gt 0 ]]
++ cat /sw/BUILD/07c975cea783c1e62a36884c93ead174a12447f1/O2Physics-code-check/errors.txt
Common/CCDB/macros/upload_event_selection_params.C:260:35: error: format specifies type 'unsigned long long' but the argument has type 'long' [clang-diagnostic-format,-warnings-as-errors]
Common/CCDB/macros/upload_event_selection_params.C:260:40: error: format specifies type 'unsigned long long' but the argument has type 'long' [clang-diagnostic-format,-warnings-as-errors]
PWGCF/Core/CorrelationContainer.cxx:634:7: error: Value stored to 'mixedNormError' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:67:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:79:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:96:103: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:98:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:102:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:104:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:109:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:110:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:111:96: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kAbsUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:117:104: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:5: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:32: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:59: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:86: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:139:31: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:178:9: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:185:5: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:198:7: error: no matching function for call to object of type 'Produces<aod::FemtoWorldParticles>' (aka 'Produces<Table<Hash<"FemtoWorldParticles"_h>, Hash<"FEMTOWORLDPARTS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:22:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:31:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:36:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:39:1: error: included header Vector4Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:40:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:73:8: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:84:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:86:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:88:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:101:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:125:111: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:140:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:144:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

code-check errors from PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx are irrelevant because the file is excluded from compilation and cannot be compiled anyway.

@alibuild

alibuild commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 14aa863 at 2026-10-10 02:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 87 errors and 1256 warnings.'
Found 87 errors and 1256 warnings.
++ [[ 87 -gt 0 ]]
++ cat /sw/BUILD/16d645775535112525ae56d0d6e1fe860f3d38f8/O2Physics-code-check/errors.txt
PWGCF/Core/CorrelationContainer.cxx:634:7: error: Value stored to 'mixedNormError' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:67:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:79:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:96:103: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:98:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:102:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:104:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:109:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:110:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:111:96: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kAbsUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:117:104: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:5: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:32: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:59: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:86: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:139:31: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:178:9: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:185:5: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:198:7: error: no matching function for call to object of type 'Produces<aod::FemtoWorldParticles>' (aka 'Produces<Table<Hash<"FemtoWorldParticles"_h>, Hash<"FEMTOWORLDPARTS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:22:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:31:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:36:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:39:1: error: included header Vector4Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:40:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:73:8: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:84:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:86:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:88:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

Dear code owners, the PR is ready for review. Please review the changes at your earliest convenience.

@vkucera

vkucera commented Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@abilandz @ddobrigk @dmallick2 @dsarkaralice @dsekihat @ekryshen @hscheid @iarsene @iouribelikov @jaelpark @jesgum @jgrosseo @ktf @lauraser @lbariogl @mcoquet642 @mfaggin @mguilbau @mpuccio @njacazio @noferini @omvazque @prottayCMT @skundu692 @smaff92 @victor-gonzalez @wenyaCern @XiaozhiBai
Dear code owners, please review the changes at your earliest convenience.

njacazio
njacazio approved these changes Oct 9, 2026
View reviewed changes

@njacazio njacazio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, super nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes
@mpuccio mpuccio mpuccio approved these changes
@nzardosh nzardosh nzardosh approved these changes
@hscheid hscheid hscheid approved these changes
@jokonig jokonig jokonig approved these changes
@maciacco maciacco maciacco approved these changes
@prchakra prchakra prchakra approved these changes
@romainschotter romainschotter romainschotter approved these changes
@dmallick2 dmallick2 dmallick2 approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@jaimenorman jaimenorman Awaiting requested review from jaimenorman jaimenorman is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@XiaozhiBai XiaozhiBai Awaiting requested review from XiaozhiBai XiaozhiBai is a code owner
@mguilbau mguilbau Awaiting requested review from mguilbau mguilbau is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@abilandz abilandz Awaiting requested review from abilandz abilandz is a code owner
@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner
@majanik majanik Awaiting requested review from majanik majanik is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@noferini noferini Awaiting requested review from noferini noferini is a code owner
@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner
@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner
@jesgum jesgum Awaiting requested review from jesgum jesgum is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner
@ekryshen ekryshen Awaiting requested review from ekryshen ekryshen is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

alice3 common datamodel dpg pwgcf pwgdq pwgem pwghf PWG-HF pwgje pwglf tutorial

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.