Skip to content

[O2-7038] DPL Analysis: correction for tpcNClsFindable overflow - #15584

Merged
ktf merged 6 commits into
AliceO2Group:devfrom
aalkin:tpc-ncls-findable-overflow-workaround
Oct 12, 2026
Merged

ktf merged 6 commits into
AliceO2Group:devfrom
aalkin:tpc-ncls-findable-overflow-workaround

Conversation

@aalkin

@aalkin aalkin commented Jul 7, 2026 •

Copy link
Copy Markdown
Member

Update: unfortunately, some of the O2Physics data model tables use some of the affected columns. To preserve compatibility, I have restored the original version and renamed the new column. The core tables are using the new column, O2Physics needs to updated separately.

@aalkin
aalkin requested a review from a team as a code owner July 7, 2026 08:32
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for b9e8be0 at 2026-07-07 11:44:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local10/include/Framework/AnalysisDataModel.h:481:1: error: no match for call to '(o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for f4adf68 at 2026-07-07 13:01:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
/sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local9/include/Framework/AnalysisDataModel.h:441:1: error: no match for call to '(o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>::boundGetter<0, 1>(std::integer_sequence<long unsigned int, 0, 1>&&) const::<lambda(uint8_t, int8_t, int8_t)>) (const unsigned char&, const signed char&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 9, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 439c52a at 2026-09-08 07:55:

## sw/BUILD/O2-full-system-test-latest/log
command alien-token-init had nonzero exit code 2


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d1914cbba84c92fcf8ead9c3a426fc07d502b412/slc9_x86-64/o2checkcode/1.0-local3/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='Python-modules-list ninja ninja-fortran pytorch_cpuinfo CMake double-conversion googlebenchmark UUID bz2 defaults-release MPFR safe_int O2-customization FairCMakeModules alibuild-recipe-tools Alice-GRID-Utils date json-c'
+ echo 'FULL_BUILD_REQUIRES=Python-modules-list ninja ninja-fortran pytorch_cpuinfo CMake double-conversion googlebenchmark UUID bz2 defaults-release MPFR safe_int O2-customization FairCMakeModules alibuild-recipe-tools Alice-GRID-Utils date json-c'
FULL_BUILD_REQUIRES=Python-modules-list ninja ninja-fortran pytorch_cpuinfo CMake double-conversion googlebenchmark UUID bz2 defaults-release MPFR safe_int O2-customization FairCMakeModules alibuild-recipe-tools Alice-GRID-Utils date json-c
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 14
+ REVISION_VALUE=14
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-14
+ '[' -z 14 ']'
+ echo 'Python-modules-list ninja ninja-fortran pytorch_cpuinfo CMake double-conversion googlebenchmark UUID bz2 defaults-release MPFR safe_int O2-customization FairCMakeModules alibuild-recipe-tools Alice-GRID-Utils date json-c'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
+ tr ' ' '\n'
[0 more errors; see full log]

Full log here.

@alcaliva
alcaliva enabled auto-merge (squash) July 22, 2026 12:49
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions Bot added the stale label Oct 9, 2026
@aalkin

aalkin commented Oct 12, 2026

Copy link
Copy Markdown
Member Author

@ktf could you please merge this one as well?

@ktf
ktf disabled auto-merge October 12, 2026 15:34
@ktf
ktf merged commit d0a7520 into AliceO2Group:dev Oct 12, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants