diff --git a/Lib/test/test_warnings/__init__.py b/Lib/test/test_warnings/__init__.py index 7262fb0d38344c0..304aef1a483d5c6 100644 --- a/Lib/test/test_warnings/__init__.py +++ b/Lib/test/test_warnings/__init__.py @@ -698,6 +698,19 @@ def test_skip_file_prefixes_type_errors(self): with self.assertRaises(TypeError): warn("msg", skip_file_prefixes="a sequence of strs") + def test_skip_file_prefixes_empty_tuple_subclass(self): + with warnings_state(self.module): + warn = warning_tests.warnings.warn + class EmptyTuple(tuple): + pass + # Passing an empty tuple subclass used to lead to a crash. + for _ in range(3): + with self.module.catch_warnings(record=True) as w: + warn("msg", skip_file_prefixes=EmptyTuple()) + self.assertEqual(len(w), 1) + self.assertEqual(w[-1].filename, __file__) + self.assertEqual(w[-1].module, __name__) + def test_exec_filename_module(self): filename = "" codeobj = compile(("import warnings\n" diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-10-19-19-33-35.gh-issue-159739.f81734.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-10-19-19-33-35.gh-issue-159739.f81734.rst new file mode 100644 index 000000000000000..0342bdef3e86994 --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-10-19-19-33-35.gh-issue-159739.f81734.rst @@ -0,0 +1,2 @@ +Fix a crash in :func:`warnings.warn` when ``skip_file_prefixes`` is an empty tuple subclass. +Propagate allocation errors when creating the fallback filename. diff --git a/Python/_warnings.c b/Python/_warnings.c index 8fecff060fdad93..86eae5deb859691 100644 --- a/Python/_warnings.c +++ b/Python/_warnings.c @@ -1053,6 +1053,9 @@ setup_context(Py_ssize_t stack_level, if (f == NULL) { globals = interp->sysdict; *filename = PyUnicode_FromString(""); + if (*filename == NULL) { + return 0; + } *lineno = 0; } else { @@ -1196,7 +1199,6 @@ warnings_warn_impl(PyObject *module, PyObject *message, PyObject *category, stacklevel = 2; } } else { - Py_DECREF((PyObject *)skip_file_prefixes); skip_file_prefixes = NULL; } }