From ac9090d1ac350e1114fabe637f9ecad612aa7ef1 Mon Sep 17 00:00:00 2001 From: Liang Hu Date: Sat, 17 Oct 2026 12:07:52 -0400 Subject: [PATCH] gh-81207: Handle socketserver timeouts at the deadline Treat an empty selector result at the deadline as a timeout instead of polling again with zero remaining time. Cover exact and elapsed deadlines, early wakeups, and ready requests with deterministic clock and selector tests. --- Lib/socketserver.py | 2 +- Lib/test/test_socketserver.py | 54 +++++++++++++++++++ ...6-10-17-11-16-05.gh-issue-81207.bX4k2P.rst | 2 + 3 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Library/2026-10-17-11-16-05.gh-issue-81207.bX4k2P.rst diff --git a/Lib/socketserver.py b/Lib/socketserver.py index ec389457ef5b1c1..908b59525bc2a81 100644 --- a/Lib/socketserver.py +++ b/Lib/socketserver.py @@ -296,7 +296,7 @@ def handle_request(self): else: if timeout is not None: timeout = deadline - time() - if timeout < 0: + if timeout <= 0: return self.handle_timeout() def _handle_request_noblock(self): diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py index ca33a9a6dac8d34..6f7f534f34cb90f 100644 --- a/Lib/test/test_socketserver.py +++ b/Lib/test/test_socketserver.py @@ -11,6 +11,7 @@ import threading import unittest import socketserver +from unittest import mock import test.support from test.support import reap_children, verbose @@ -467,6 +468,59 @@ def run_client(): class MiscTestCase(unittest.TestCase): + def test_handle_request_timeout_at_deadline(self): + # Let a second poll advance past the deadline so a regression fails + # instead of looping forever on a frozen clock. + cases = ( + (0, [10, 10, 11], [0]), + (1, [10, 11, 12], [1]), + (1, [10, 10.25, 11, 12], [1, 0.75]), + (1, [10, 11.25], [1]), + ) + for timeout, clock, expected_timeouts in cases: + with self.subTest(timeout=timeout, clock=clock): + with socketserver.TCPServer( + (HOST, 0), socketserver.BaseRequestHandler + ) as server: + server.timeout = timeout + with ( + mock.patch('socketserver.time', side_effect=clock), + mock.patch('socketserver._ServerSelector') as selector_cls, + mock.patch.object( + server, 'handle_timeout', + return_value=mock.sentinel.timeout, + ) as handle_timeout, + ): + selector = selector_cls.return_value.__enter__.return_value + selector.select.return_value = [] + result = server.handle_request() + self.assertIs(result, mock.sentinel.timeout) + self.assertEqual(selector.select.call_args_list, + [mock.call(t) for t in expected_timeouts]) + handle_timeout.assert_called_once_with() + + def test_handle_request_ready_with_zero_timeout(self): + with socketserver.TCPServer( + (HOST, 0), socketserver.BaseRequestHandler + ) as server: + server.timeout = 0 + with ( + mock.patch('socketserver.time', return_value=10), + mock.patch('socketserver._ServerSelector') as selector_cls, + mock.patch.object( + server, '_handle_request_noblock', + return_value=mock.sentinel.request, + ) as handle_request, + mock.patch.object(server, 'handle_timeout') as handle_timeout, + ): + selector = selector_cls.return_value.__enter__.return_value + selector.select.return_value = [mock.sentinel.ready] + result = server.handle_request() + self.assertIs(result, mock.sentinel.request) + selector.select.assert_called_once_with(0) + handle_request.assert_called_once_with() + handle_timeout.assert_not_called() + def test_all(self): # objects defined in the module should be in __all__ expected = [] diff --git a/Misc/NEWS.d/next/Library/2026-10-17-11-16-05.gh-issue-81207.bX4k2P.rst b/Misc/NEWS.d/next/Library/2026-10-17-11-16-05.gh-issue-81207.bX4k2P.rst new file mode 100644 index 000000000000000..cfa5c3613559beb --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-10-17-11-16-05.gh-issue-81207.bX4k2P.rst @@ -0,0 +1,2 @@ +Fix a potential busy loop in :meth:`socketserver.BaseServer.handle_request` +when the timeout expires exactly at the deadline.