Skip to content

Update dataflow library - #1154

Open
mbaluda wants to merge 1 commit into
mainfrom
mbaluda-next-merge
Open

Update dataflow library#1154
mbaluda wants to merge 1 commit into
mainfrom
mbaluda-next-merge

Conversation

@mbaluda

@mbaluda mbaluda commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR migrates queries and shared libraries from the deprecated AST-based dataflow APIs to the IR-based semmle.code.cpp.dataflow.new implementation.
The migration updates flow configurations for use-use dataflow and standard-library models.

User-visible changes
ENV30-C, RULE-21-19, RULE-25-5-2: removes duplicate alerts for the same modification of a pointer returned by an environment or locale function.
RULE-14-3: reports invariant-false loop conditions that use the integer literal 0, including compound controlling expressions.
ARR30-C: a negative out-of-bounds access may produce a result for each buffer expression reaching that access.
ARR38-C, RULE-21-17, RULE-21-18, RULE-8-7-1: corrects strncat and wcsncat modeling. Destinations must be null-terminated, while sources need not contain a null terminator within the specified character limit.
Internal changes
Migrates direct rule queries including EXP30-C, EXP50-CPP, MEM52-CPP, MEM53-CPP, A18-1-4, RULE-0-1-1, and RULE-14-3.
Adapts path queries to the new node and access-path representations.

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • A18-1-4
    • ENV30-C
    • EXP30-C
    • EXP50-CPP
    • INT31-C
    • MEM52-CPP
    • MEM53-CPP
    • RULE-0-1-1
    • RULE-1-2
    • RULE-14-3
    • RULE-21-19
    • RULE-25-5-2

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Copilot AI review requested due to automatic review settings June 30, 2026 15:16
@mbaluda mbaluda changed the title Mbaluda next merge Merge branch next and update CodeQL Jun 30, 2026
GitHub Advanced Security started work on behalf of mbaluda June 30, 2026 15:17 View session
GitHub Advanced Security finished work on behalf of mbaluda June 30, 2026 15:17
Copilot AI reviewed Jun 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the repository’s CodeQL toolchain and pack dependencies (notably moving to CodeQL CLI 2.23.3 and codeql/cpp-all 6.0.0), while updating many C/C++ coding-standards queries to newer dataflow/taint-tracking and concurrency libraries. It also refreshes a large set of unit test .expected outputs and adds a change note documenting the version bump and query behavior adjustments.

Changes:

  • Bump supported CodeQL environment to 2.23.3 and update CodeQL pack dependencies/locks (including codeql/cpp-all: 6.0.0).
  • Migrate many queries and shared libraries from deprecated dataflow/taint-tracking/concurrency modules to ...dataflow.new... and ConcurrencyNew.
  • Update unit tests and .expected files to reflect changed query outputs; add a change note for the upgrade.

Checklist items uncertain (not confirmed in this review):

  • Shared query format validation in VS Code (per PR checklist).
  • Performance/result validation on OpenPilot (per PR checklist).
Show a summary per file
File Description
supported_codeql_configs.json Updates supported CodeQL CLI/stdlib/bundle versions to 2.23.3.
scripts/generate_modules/queries/qlpack.yml Bumps extraction pack dependency to codeql/cpp-all: 6.0.0.
scripts/generate_modules/queries/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for extraction pack.
cpp/report/src/qlpack.yml Bumps report pack dependency to codeql/cpp-all: 6.0.0.
cpp/report/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for report pack.
cpp/misra/test/rules/RULE-8-2-8/test.cpp Adjusts compliance annotation for template variable cast test.
cpp/misra/test/rules/RULE-8-2-8/PointerToIntegralCast.expected Updates expected results/locations for RULE-8-2-8 tests.
cpp/misra/test/rules/RULE-19-2-2/test.cpp Updates test annotation to remove false-negative marker.
cpp/misra/test/rules/RULE-19-2-2/InvalidIncludeDirective.expected Adds/updates expected result for invalid include directive.
cpp/misra/test/rules/RULE-15-1-3/NonExplicitConversionMember.expected Updates expected conversion-operator name formatting.
cpp/misra/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for MISRA C++ tests.
cpp/misra/src/rules/RULE-8-7-1/PointerArithmeticFormsAnInvalidPointer.ql Updates imports/types for new dataflow and SSA internals.
cpp/misra/src/rules/RULE-0-1-1/UnnecessaryWriteToLocalObject.ql Switches to semmle.code.cpp.dataflow.new.DataFlow.
cpp/misra/src/qlpack.yml Bumps MISRA C++ pack dependency to codeql/cpp-all: 6.0.0.
cpp/misra/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for MISRA C++ pack.
cpp/common/test/rules/throwingoperatornewreturnsnull/ThrowingOperatorNewReturnsNull.expected Updates path-problem expected output structure.
cpp/common/test/rules/movedfromobjectsunspecifiedstate/MovedFromObjectsUnspecifiedState.expected Updates expected output to match new flow nodes/labels.
cpp/common/test/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.expected Updates expected output to match new flow nodes/labels.
cpp/common/test/rules/danglingcapturewhenreturninglambdaobject/DanglingCaptureWhenReturningLambdaObject.expected Updates expected results to remove duplicate/changed row.
cpp/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected Updates expected output to match new flow nodes/labels.
cpp/common/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for common C++ tests.
cpp/common/src/qlpack.yml Bumps common C++ pack dependency to codeql/cpp-all: 6.0.0.
cpp/common/src/codingstandards/cpp/standardlibrary/STLContainers.qll Migrates to new taint tracking; adjusts local taint helper.
cpp/common/src/codingstandards/cpp/standardlibrary/FileStreams.qll Migrates to new taint tracking imports.
cpp/common/src/codingstandards/cpp/SmartPointers.qll Migrates to semmle.code.cpp.dataflow.new.DataFlow.
cpp/common/src/codingstandards/cpp/SideEffect.qll Migrates to semmle.code.cpp.dataflow.new.DataFlow.
cpp/common/src/codingstandards/cpp/rules/wrapspuriousfunctioninloop/WrapSpuriousFunctionInLoop.qll Switches to ConcurrencyNew.
cpp/common/src/codingstandards/cpp/rules/useonlyarrayindexingforpointerarithmetic/UseOnlyArrayIndexingForPointerArithmetic.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/unusedtypedeclarations/UnusedTypeDeclarations.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/rules/unsignedoperationwithconstantoperandswraps/UnsignedOperationWithConstantOperandsWraps.qll Updates guard-condition handling logic.
cpp/common/src/codingstandards/cpp/rules/unnecessaryexposedidentifierdeclarationshared/UnnecessaryExposedIdentifierDeclarationShared.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/rules/throwingoperatornewreturnsnull/ThrowingOperatorNewReturnsNull.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/stringnumberconversionmissingerrorcheck/StringNumberConversionMissingErrorCheck.qll Migrates to new TaintTracking.
cpp/common/src/codingstandards/cpp/rules/preventdeadlockbylockinginpredefinedorder/PreventDeadlockByLockingInPredefinedOrder.qll Switches to ConcurrencyNew.
cpp/common/src/codingstandards/cpp/rules/preservesafetywhenusingconditionvariables/PreserveSafetyWhenUsingConditionVariables.qll Switches to ConcurrencyNew.
cpp/common/src/codingstandards/cpp/rules/predicatefunctionobjectsshouldnotbemutable/PredicateFunctionObjectsShouldNotBeMutable.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/placementnewnotproperlyaligned/PlacementNewNotProperlyAligned.qll Removes deprecated DataFlow import (uses path graph).
cpp/common/src/codingstandards/cpp/rules/placementnewinsufficientstorage/PlacementNewInsufficientStorage.qll Removes deprecated DataFlow import (uses path graph).
cpp/common/src/codingstandards/cpp/rules/ownedpointervaluestoredinunrelatedsmartpointer/OwnedPointerValueStoredInUnrelatedSmartPointer.qll Migrates to new TaintTracking.
cpp/common/src/codingstandards/cpp/rules/onlyfreememoryallocateddynamicallyshared/OnlyFreeMemoryAllocatedDynamicallyShared.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/nonvoidfunctiondoesnotreturn/NonVoidFunctionDoesNotReturn.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/rules/nonconstantformat/NonConstantFormat.qll Migrates to new TaintTracking.
cpp/common/src/codingstandards/cpp/rules/multipleglobalormemberdeclarators/MultipleGlobalOrMemberDeclarators.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/rules/movedfromobjectsunspecifiedstate/MovedFromObjectsUnspecifiedState.qll Migrates to new DataFlow and updates flow logic.
cpp/common/src/codingstandards/cpp/rules/joinordetachthreadonlyonce/JoinOrDetachThreadOnlyOnce.qll Switches to ConcurrencyNew.
cpp/common/src/codingstandards/cpp/rules/iofstreammissingpositioning/IOFstreamMissingPositioning.qll Removes deprecated TaintTracking import (via shared libs).
cpp/common/src/codingstandards/cpp/rules/invalidatedenvstringpointers/InvalidatedEnvStringPointers.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/guardaccesstobitfields/GuardAccessToBitFields.qll Switches to ConcurrencyNew.
cpp/common/src/codingstandards/cpp/rules/functionerroneousreturnvaluenottested/FunctionErroneousReturnValueNotTested.qll Migrates to new DataFlow and updates guard-detection logic.
cpp/common/src/codingstandards/cpp/rules/donotuserelationaloperatorswithdifferingarrays/DoNotUseRelationalOperatorsWithDifferingArrays.qll Migrates to new DataFlow and adds barrier handling.
cpp/common/src/codingstandards/cpp/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.qll Migrates to new DataFlow and adds barrier handling.
cpp/common/src/codingstandards/cpp/rules/donotpassaliasedpointertorestrictqualifiedparamshared/DoNotPassAliasedPointerToRestrictQualifiedParamShared.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/donotaccessaclosedfile/DoNotAccessAClosedFile.qll Migrates to new DataFlow and updates local-flow node usage.
cpp/common/src/codingstandards/cpp/rules/danglingcapturewhenreturninglambdaobject/DanglingCaptureWhenReturningLambdaObject.qll Migrates to new DataFlow and updates lambda-to-return flow.
cpp/common/src/codingstandards/cpp/rules/danglingcapturewhenmovinglambdaobject/DanglingCaptureWhenMovingLambdaObject.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/containeraccesswithoutrangecheck/ContainerAccessWithoutRangeCheck.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/constlikereturnvalue/ConstLikeReturnValue.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/rules/basicstringmaynotbenullterminated/BasicStringMayNotBeNullTerminated.qll Migrates to new taint tracking and updates node usage.
cpp/common/src/codingstandards/cpp/ReadErrorsAndEOF.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/Overflow.qll Adjusts imports (notably dataflow/taint tracking).
cpp/common/src/codingstandards/cpp/OutOfBounds.qll Removes deprecated DataFlow import (relies on other modules).
cpp/common/src/codingstandards/cpp/MistypedFunctionArguments.qll Simplifies recursion for “compiled as C” detection.
cpp/common/src/codingstandards/cpp/Loops.qll Updates unknown-location handling types.
cpp/common/src/codingstandards/cpp/Iterators.qll Migrates to new TaintTracking and updates imports.
cpp/common/src/codingstandards/cpp/Identifiers.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/FgetsErrorManagement.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/Expr.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/deadcode/UnusedVariables.qll Updates template-parameter type usage for newer libs.
cpp/common/src/codingstandards/cpp/ConstHelpers.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/ConcurrencyNew.qll Adds a new umbrella module for updated concurrency modeling.
cpp/common/src/codingstandards/cpp/concurrency/ThreadSpecificStorageNew.qll Adds new thread-specific storage modeling using new dataflow.
cpp/common/src/codingstandards/cpp/Allocations.qll Migrates to new DataFlow.
cpp/common/src/codingstandards/cpp/AccessPath.qll Migrates to new DataFlow.
cpp/common/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for common C++ pack.
cpp/cert/test/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.expected Removes deprecated-module warning from expected output.
cpp/cert/test/rules/MEM52-CPP/DetectAndHandleMemoryAllocationErrors.expected Removes deprecated-module warnings from expected output.
cpp/cert/test/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.expected Updates expected path-problem output structure.
cpp/cert/test/rules/CTR53-CPP/UseValidIteratorRanges.expected Removes deprecated-module warnings from expected output.
cpp/cert/test/rules/CTR52-CPP/GuaranteeGenericCppLibraryFunctionsDoNotOverflow.expected Removes deprecated-module warnings from expected output.
cpp/cert/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for CERT C++ tests.
cpp/cert/src/rules/MSC51-CPP/BadlySeededRandomNumberGenerator.ql Migrates to new TaintTracking.
cpp/cert/src/rules/MEM52-CPP/DetectAndHandleMemoryAllocationErrors.ql Migrates to new DataFlow and updates guard detection.
cpp/cert/src/rules/EXP50-CPP/DoNotDependOnTheOrderOfScalarObjectEvaluationForSideEffects.ql Fixes typo/formatting in alert message.
cpp/cert/src/rules/EXP50-CPP/DoNotDependOnTheOrderOfEvaluationForSideEffectsInFunctionCallsAsFunctionArguments.ql Adjusts imports (removes redundant DataFlow import).
cpp/cert/src/rules/CTR56-CPP/DoNotUsePointerArithmeticOnPolymorphicObjects.ql Migrates to new DataFlow.
cpp/cert/src/rules/CTR55-CPP/DoNotUseAnAdditiveOperatorOnAnIterator.ql Updates expression handling for guard checks.
cpp/cert/src/rules/CTR53-CPP/UseValidIteratorRanges.ql Migrates to new DataFlow.
cpp/cert/src/rules/CTR52-CPP/GuaranteeGenericCppLibraryFunctionsDoNotOverflow.ql Migrates to new TaintTracking.
cpp/cert/src/rules/CON56-CPP/LockedALockedNonRecursiveMutexAudit.ql Switches to ConcurrencyNew.
cpp/cert/src/rules/CON56-CPP/DoNotSpeculativelyLockALockedNonRecursiveMutex.ql Switches to ConcurrencyNew.
cpp/cert/src/qlpack.yml Bumps CERT C++ pack dependency to codeql/cpp-all: 6.0.0.
cpp/cert/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for CERT C++ pack.
cpp/autosar/test/rules/M9-3-1/ConstMemberFunctionReturnsNonConstPointer.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/M3-9-3/UnderlyingBitRepresentationsOfFloatingPointValuesUsed.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A9-3-1/ReturnsNonConstRawPointersOrReferencesToPrivateOrProtectedData.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A8-4-9/InOutParametersDeclaredAsTNotModified.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A8-4-12/UniquePtrPassedToFunctionWithImproperSemantics.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A8-4-11/SmartPointerAsParameterWithoutLifetimeSemantics.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A7-5-1/InvalidFunctionReturnType.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A5-1-7/LambdaPassedToTypeid.expected Updates expected path-problem output structure.
cpp/autosar/test/rules/A5-1-7/LambdaPassedToDecltype.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A5-0-4/PointerArithmeticUsedWithPointersToNonFinalClasses.expected Updates expected path-problem output structure.
cpp/autosar/test/rules/A27-0-4/CStyleStringsUsed.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A20-8-4/SharedPointerUsedWithNoOwnershipSharing.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A18-9-4/ArgumentToForwardSubsequentlyUsed.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A15-2-2/ConstructorErrorLeavesObjectInInvalidState.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A15-1-3/ThrownExceptionsShouldBeUnique.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A13-5-3/UserDefinedConversionOperatorsShouldNotBeUsed.expected Updates expected operator-string formatting.
cpp/autosar/test/rules/A13-2-1/AssignmentOperatorReturnThis.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/rules/A13-1-3/UserDefinedLiteralsOperatorsShallOnlyPerformConversionOfPassedParameters.expected Removes deprecated-module warnings from expected output.
cpp/autosar/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for AUTOSAR C++ tests.
cpp/autosar/src/rules/M9-3-1/ConstMemberFunctionReturnsNonConstPointer.ql Migrates to new DataFlow and updates local-flow node usage.
cpp/autosar/src/rules/M5-0-17/PointerSubtractionOnDifferentArrays.ql Migrates to new DataFlow and adds barrier handling.
cpp/autosar/src/rules/M3-9-3/UnderlyingBitRepresentationsOfFloatingPointValuesUsed.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A9-3-1/ReturnsNonConstRawPointersOrReferencesToPrivateOrProtectedData.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A8-4-9/InOutParametersDeclaredAsTNotModified.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A8-4-12/UniquePtrPassedToFunctionWithImproperSemantics.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A8-4-11/SmartPointerAsParameterWithoutLifetimeSemantics.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A7-5-1/InvalidFunctionReturnType.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A5-1-7/LambdaPassedToTypeid.ql Migrates to new DataFlow and updates sink-node selection.
cpp/autosar/src/rules/A5-1-7/LambdaPassedToDecltype.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A5-0-4/PointerArithmeticUsedWithPointersToNonFinalClasses.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A4-7-1/IntegerExpressionLeadToDataLoss.ql Updates guard-condition handling logic.
cpp/autosar/src/rules/A27-0-4/CStyleStringsUsed.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A20-8-4/SharedPointerUsedWithNoOwnershipSharing.ql Migrates to new DataFlow and updates local-flow node usage.
cpp/autosar/src/rules/A18-9-4/ArgumentToForwardSubsequentlyUsed.ql Migrates to new DataFlow and updates defining-argument usage.
cpp/autosar/src/rules/A15-2-2/ConstructorErrorLeavesObjectInInvalidState.ql Migrates to new DataFlow and introduces dedicated new/delete flow config.
cpp/autosar/src/rules/A15-1-3/ThrownExceptionsShouldBeUnique.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A13-2-1/AssignmentOperatorReturnThis.ql Migrates to new DataFlow.
cpp/autosar/src/rules/A13-1-3/UserDefinedLiteralsOperatorsShallOnlyPerformConversionOfPassedParameters.ql Migrates to new TaintTracking.
cpp/autosar/src/qlpack.yml Bumps AUTOSAR C++ pack dependency to codeql/cpp-all: 6.0.0.
cpp/autosar/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for AUTOSAR C++ pack.
change_notes/2026-06-25-upgrade-to-2.23.3.md Adds change note documenting the CodeQL upgrade and query changes.
c/misra/test/rules/RULE-22-7/EofShallBeComparedWithUnmodifiedReturnValues.expected Removes deprecated-module warnings from expected output.
c/misra/test/rules/RULE-22-4/AttemptToWriteToAReadOnlyStream.expected Removes deprecated-module warnings from expected output.
c/misra/test/rules/RULE-22-3/FileOpenForReadAndWriteOnDifferentStreams.expected Removes deprecated-module warnings from expected output.
c/misra/test/rules/RULE-2-4/UnusedTagDeclaration.expected Updates expected output (removes one result).
c/misra/test/rules/RULE-2-4/test.c Adjusts compliant annotation text/wrapping.
c/misra/test/rules/RULE-17-5/ArrayFunctionArgumentNumberOfElements.expected Removes deprecated-module warnings from expected output.
c/misra/test/rules/RULE-13-2/UnsequencedAtomicReads.expected Removes deprecated-module warnings from expected output.
c/misra/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for MISRA C tests.
c/misra/src/rules/RULE-22-7/EofShallBeComparedWithUnmodifiedReturnValues.ql Migrates to new DataFlow.
c/misra/src/rules/RULE-22-4/AttemptToWriteToAReadOnlyStream.ql Migrates to new DataFlow.
c/misra/src/rules/RULE-22-3/FileOpenForReadAndWriteOnDifferentStreams.ql Migrates to new DataFlow.
c/misra/src/rules/RULE-22-20/ThreadStoragePointerInitializedInsideThread.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-20/ThreadStorageNotInitializedBeforeUse.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-19/ConditionVariableUsedWithMultipleMutexes.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLockedAudit.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-18/NonRecursiveMutexRecursivelyLocked.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-17/InvalidOperationOnUnlockedMutex.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-15/ThreadResourceDisposedBeforeThreadsJoined.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-14/MutexNotInitializedBeforeUse.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-14/MutexInitWithInvalidMutexType.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-14/MutexInitializedInsideThread.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-13/ThreadingObjectWithInvalidStorageDuration.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-22-12/NonstandardUseOfThreadingObject.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-21-14/MemcmpUsedToCompareNullTerminatedStrings.ql Migrates to new TaintTracking and updates node conversions.
c/misra/src/rules/RULE-18-6/ThreadLocalObjectAddressCopiedToGlobalObject.ql Switches to ConcurrencyNew.
c/misra/src/rules/RULE-17-5/ArrayFunctionArgumentNumberOfElements.ql Migrates to new DataFlow and updates sink-node selection.
c/misra/src/rules/RULE-13-2/UnsequencedAtomicReads.ql Migrates to new TaintTracking.
c/misra/src/rules/DIR-5-3/ThreadCreatedByThread.ql Switches to ConcurrencyNew.
c/misra/src/rules/DIR-5-3/BannedDynamicThreadCreation.ql Switches to ConcurrencyNew.
c/misra/src/rules/DIR-5-1/PossibleDataRaceBetweenThreads.ql Updates imports to use ConcurrencyNew and refactors module deps.
c/misra/src/qlpack.yml Bumps MISRA C pack dependency to codeql/cpp-all: 6.0.0.
c/misra/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for MISRA C pack.
c/common/test/rules/onlyfreememoryallocateddynamicallyshared/OnlyFreeMemoryAllocatedDynamicallyShared.expected Updates expected path-problem output structure.
c/common/test/rules/donotsubtractpointersaddressingdifferentarrays/DoNotSubtractPointersAddressingDifferentArrays.expected Updates expected path-problem output structure.
c/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected Updates expected path-problem output structure.
c/common/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for common C tests.
c/common/src/qlpack.yml Bumps common C pack dependency to codeql/cpp-all: 6.0.0.
c/common/src/codingstandards/c/Signal.qll Migrates to new DataFlow.
c/common/src/codingstandards/c/OutOfBounds.qll Removes deprecated DataFlow import (relies on other modules).
c/common/src/codingstandards/c/initialization/GlobalInitializationAnalysis.qll Switches to ConcurrencyNew.
c/common/src/codingstandards/c/Extensions.qll Updates extension detection logic for real-type extensions.
c/common/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for common C pack.
c/cert/test/rules/STR31-C/StringsHasSufficientSpaceForTheNullTerminator.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/SIG35-C/DoNotReturnFromAComputationalExceptionHandler.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/MSC33-C/DoNotPassInvalidDataToTheAsctimeFunction.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.expected Updates expected path-problem output structure.
c/cert/test/rules/MEM35-C/InsufficientMemoryAllocatedForObject.expected Updates expected output (includes remaining deprecation warnings).
c/cert/test/rules/INT31-C/test.c Updates compliance annotations for integer conversion tests.
c/cert/test/rules/INT31-C/IntegerConversionCausesDataLoss.expected Adds expected findings for new/adjusted INT31-C cases.
c/cert/test/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/FIO40-C/ResetStringsOnFgetsOrFgetwsFailure.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.expected Updates expected messages for EXP37-C.
c/cert/test/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/ERR30-C/SetlocaleMightSetErrno.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/ERR30-C/ErrnoReadBeforeReturn.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.expected Updates expected output structure/locations.
c/cert/test/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/CON34-C/AppropriateThreadObjectStorageDurations.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/CON30-C/CleanUpThreadSpecificStorage.expected Removes deprecated-module warnings from expected output.
c/cert/test/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.expected Updates expected path-problem output structure.
c/cert/test/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.expected Updates expected path-problem output structure.
c/cert/test/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for CERT C tests.
c/cert/src/rules/STR31-C/StringsHasSufficientSpaceForTheNullTerminator.ql Migrates to new TaintTracking.
c/cert/src/rules/SIG35-C/DoNotReturnFromAComputationalExceptionHandler.ql Migrates to new DataFlow.
c/cert/src/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.ql Migrates to new DataFlow.
c/cert/src/rules/MSC33-C/DoNotPassInvalidDataToTheAsctimeFunction.ql Migrates to new DataFlow and updates sink modeling.
c/cert/src/rules/MEM36-C/DoNotModifyAlignmentOfMemoryWithRealloc.ql Migrates to new DataFlow.
c/cert/src/rules/MEM35-C/InsufficientMemoryAllocatedForObject.ql Adjusts imports (removes deprecated TaintTracking direct import).
c/cert/src/rules/FIO45-C/ToctouRaceConditionsWhileAccessingFiles.ql Migrates to new DataFlow.
c/cert/src/rules/FIO44-C/OnlyUseValuesForFsetposThatAreReturnedFromFgetpos.ql Migrates to new DataFlow and updates by-ref argument nodes.
c/cert/src/rules/FIO40-C/ResetStringsOnFgetsOrFgetwsFailure.ql Migrates to new DataFlow.
c/cert/src/rules/FIO37-C/SuccessfulFgetsOrFgetwsMayReturnAnEmptyString.ql Migrates to new DataFlow.
c/cert/src/rules/EXP40-C/DoNotModifyConstantObjects.ql Migrates to new DataFlow.
c/cert/src/rules/EXP37-C/DoNotCallFunctionsWithIncompatibleArguments.ql Updates alert message text and formatting.
c/cert/src/rules/EXP37-C/DoNotCallFunctionPointerWithIncompatibleType.ql Migrates to new DataFlow and adds type mismatch guard.
c/cert/src/rules/EXP36-C/DoNotCastPointerToMoreStrictlyAlignedPointerType.ql Migrates to new DataFlow.
c/cert/src/rules/EXP30-C/DependenceOnOrderOfFunctionArgumentsForSideEffects.ql Migrates to new TaintTracking.
c/cert/src/rules/EXP16-C/DoNotCompareFunctionPointersToConstantValues.ql Updates guard-condition modeling for implicit comparisons.
c/cert/src/rules/ERR33-C/DetectAndHandleStandardLibraryErrors.ql Migrates to new DataFlow.
c/cert/src/rules/ERR32-C/DoNotRelyOnIndeterminateValuesOfErrno.ql Migrates to new DataFlow.
c/cert/src/rules/ERR30-C/SetlocaleMightSetErrno.ql Migrates to new DataFlow.
c/cert/src/rules/ERR30-C/ErrnoReadBeforeReturn.ql Migrates to new DataFlow.
c/cert/src/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.ql Migrates to new DataFlow and updates sink modeling.
c/cert/src/rules/CON41-C/WrapFunctionsThatCanFailSpuriouslyInLoop.ql Switches to ConcurrencyNew.
c/cert/src/rules/CON40-C/AtomicVariableTwiceInExpression.ql Switches to ConcurrencyNew.
c/cert/src/rules/CON37-C/DoNotCallSignalInMultithreadedProgram.ql Switches to ConcurrencyNew.
c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql Switches to ConcurrencyNew and migrates to new DataFlow.
c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql Switches to ConcurrencyNew and migrates to new DataFlow.
c/cert/src/rules/CON33-C/RaceConditionsWhenUsingLibraryFunctions.ql Switches to ConcurrencyNew.
c/cert/src/rules/CON30-C/CleanUpThreadSpecificStorage.ql Switches to ConcurrencyNew and migrates to new DataFlow; updates barriers.
c/cert/src/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.ql Migrates to new TaintTracking and adjusts scaled-integer detection.
c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql Migrates to new DataFlow.
c/cert/src/qlpack.yml Bumps CERT C pack dependency to codeql/cpp-all: 6.0.0.
c/cert/src/codeql-pack.lock.yml Refreshes locked CodeQL dependency versions for CERT C pack.

Review details

Comments suppressed due to low confidence (1)

c/common/src/codingstandards/c/Extensions.qll:127

  • CRealTypeExtensionExtension now matches Float128Type, but the diagnostic message still says "Decimal floats". This will produce misleading results for users.
  • Files reviewed: 244/244 changed files
  • Comments generated: 5
  • Review effort level: Low

Comment thread c/cert/src/rules/EXP16-C/DoNotCompareFunctionPointersToConstantValues.ql
Comment thread ...ds/cpp/rules/functionerroneousreturnvaluenottested/FunctionErroneousReturnValueNotTested.qll
Comment thread cpp/common/src/codingstandards/cpp/Overflow.qll Outdated
Comment thread cpp/common/src/codingstandards/cpp/standardlibrary/STLContainers.qll Outdated
Comment thread c/cert/test/rules/MEM35-C/InsufficientMemoryAllocatedForObject.expected Outdated
@mbaluda
mbaluda requested review from a team, MichaelRFairhurst and knewbury01 June 30, 2026 15:30
@codeql-coding-standards-automation

codeql-coding-standards-automation Bot commented Jun 30, 2026

Copy link
Copy Markdown

🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details.

GitHub Advanced Security started work on behalf of mbaluda June 30, 2026 17:59 View session
GitHub Advanced Security finished work on behalf of mbaluda June 30, 2026 18:00
GitHub Advanced Security started work on behalf of mbaluda June 30, 2026 18:15 View session
GitHub Advanced Security finished work on behalf of mbaluda June 30, 2026 18:16
@mbaluda
mbaluda force-pushed the mbaluda-next-merge branch from b5970a4 to d66ec8d Compare August 17, 2026 10:20
@mbaluda
mbaluda requested a balanced review from Copilot August 18, 2026 08:51
Copilot AI reviewed Aug 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 245/245 changed files
  • Comments generated: 10
  • Review effort level: Balanced

Comment thread c/cert/test/rules/SIG30-C/CallOnlyAsyncSafeFunctionsWithinSignalHandlers.expected Outdated
Comment thread c/common/src/codingstandards/c/Extensions.qll Outdated
Comment thread c/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected
Comment thread cpp/common/test/rules/constlikereturnvalue/ConstLikeReturnValue.expected
Comment thread cpp/common/test/rules/unusedtypedeclarations/test.cpp Outdated
Comment thread c/cert/test/rules/INT31-C/test.c
Comment thread supported_codeql_configs.json
Comment thread cpp/common/src/codingstandards/cpp/ConcurrencyNew.qll
Comment thread cpp/common/src/codingstandards/cpp/concurrency/ThreadSpecificStorageNew.qll
Comment thread c/misra/test/rules/RULE-14-3/test.c Outdated
@MichaelRFairhurst

MichaelRFairhurst commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

/test-performance

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@mbaluda mbaluda changed the title Merge branch next and update CodeQL Merge branch next and update CodeQL to v2.23.9 Aug 24, 2026
@mbaluda

mbaluda commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

/test-performance

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@codeql-coding-standards-automation

codeql-coding-standards-automation Bot commented Sep 3, 2026

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 


Release                            : v2.61.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4615626
Mean_Predicate_Execution_Time_Ms   : 64.84988900441172
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 574.4148904892992
Total_Serialized_Execution_Time_s  : 4615.626
Mean_Query_Execution_Time_s        : 0.0648498890044117
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71174

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3266370
Mean_Predicate_Execution_Time_Ms   : 63.90362718628947
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 503.1579843913974
Total_Serialized_Execution_Time_s  : 3266.37
Mean_Query_Execution_Time_s        : 0.0639036271862894
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 191.0
Number_of_Predicates               : 51114

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4756186
Mean_Predicate_Execution_Time_Ms   : 66.62911337433282
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 451.0173047967091
Total_Serialized_Execution_Time_s  : 4756.186
Mean_Query_Execution_Time_s        : 0.0666291133743328
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 208.0
Number_of_Predicates               : 71383

Release                            : v2.61.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2784651
Mean_Predicate_Execution_Time_Ms   : 54.388777124553215
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 610.0917903271135
Total_Serialized_Execution_Time_s  : 2784.651
Mean_Query_Execution_Time_s        : 0.0543887771245532
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 142.0
Number_of_Predicates               : 51199

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2655267
Mean_Predicate_Execution_Time_Ms   : 51.8738546896673
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 558.1246726024739
Total_Serialized_Execution_Time_s  : 2655.267
Mean_Query_Execution_Time_s        : 0.0518738546896673
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 138.0
Number_of_Predicates               : 51187

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4355006
Mean_Predicate_Execution_Time_Ms   : 61.04492507814581
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 537.0863746976181
Total_Serialized_Execution_Time_s  : 4355.006
Mean_Query_Execution_Time_s        : 0.0610449250781458
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71341

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4958885
Mean_Predicate_Execution_Time_Ms   : 69.36085545640194
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 468.2069608070895
Total_Serialized_Execution_Time_s  : 4958.885
Mean_Query_Execution_Time_s        : 0.0693608554564019
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 218.0
Number_of_Predicates               : 71494

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3809287
Mean_Predicate_Execution_Time_Ms   : 74.47432012356057
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 607.469703694893
Total_Serialized_Execution_Time_s  : 3809.287
Mean_Query_Execution_Time_s        : 0.0744743201235605
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 196.0
Number_of_Predicates               : 51149

Release                            : 1154
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2217016
Mean_Predicate_Execution_Time_Ms   : 40.346060054595085
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 408.96920394440286
Total_Serialized_Execution_Time_s  : 2217.016
Mean_Query_Execution_Time_s        : 0.040346060054595
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 115.0
Number_of_Predicates               : 54950

Release                            : 1154
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 7401267
Mean_Predicate_Execution_Time_Ms   : 96.4384723633805
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 5392.4687659746405
Total_Serialized_Execution_Time_s  : 7401.267
Mean_Query_Execution_Time_s        : 0.0964384723633805
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 154.0
Number_of_Predicates               : 76746

🏁 Below are the slowest predicates for the last 2 releases vs this PR. 


Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 28287

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 29311

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 33680

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 31340

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 39979

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 23074

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 24488

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : cert-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 26535

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 35596

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : VirtualDispatchPrototype::VirtualDispatch::cannotInheritHelper/4#7c75bd87
Execution_Time_Ms : 27766

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : Dependency::dependsOnTransitive/2#cbda84a0
Execution_Time_Ms : 26611

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 18257

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 25356

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 25854

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 31549

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 36107

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 32647

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 35486

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CheckedException::CheckedException#b0aa5ec8
Execution_Time_Ms : 27027

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 40850

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : cert-default
Predicate         : STLContainers::localTaint/2#d71eeced
Execution_Time_Ms : 452752

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : STLContainers::localTaint/2#d71eeced
Execution_Time_Ms : 592030

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : STLContainers::localTaint/2#d71eeced_10#join_rhs
Execution_Time_Ms : 881281

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 28481

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : HoldsForAllCopies::HoldsForAllCopies<DeadCode::DeadOperationInstance,Expr::Expr>::RelevantElement#acaf8a9e
Execution_Time_Ms : 27849

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : AlertReporting::MacroUnwrapper<Expr::Expr>::getAMacroInvocation/1#942dfbb7
Execution_Time_Ms : 22013

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : SmartPointers::localExprFlow/2#e8a2b02b
Execution_Time_Ms : 66957

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : cert-default
Predicate         : STLContainers::localTaint/2#d71eeced_10#join_rhs
Execution_Time_Ms : 934250

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 30172

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 20516

@MichaelRFairhurst

MichaelRFairhurst commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Looks like performance has still regressed, with these slow predicates:


Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : cert-default
Predicate         : STLContainers::localTaint/2#d71eeced
Execution_Time_Ms : 452752

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : STLContainers::localTaint/2#d71eeced
Execution_Time_Ms : 592030

Release           : 1154
Run               : 2026-09-02_21-42-20
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : STLContainers::localTaint/2#d71eeced_10#join_rhs
Execution_Time_Ms : 881281

@mbaluda mbaluda changed the title Merge branch next and update CodeQL to v2.23.9 Update dataflow library Sep 24, 2026
@mbaluda

mbaluda commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

/test-performance

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

@codeql-coding-standards-automation

codeql-coding-standards-automation Bot commented Sep 24, 2026

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 


Release                            : v2.61.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4615626
Mean_Predicate_Execution_Time_Ms   : 64.84988900441172
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 574.4148904892992
Total_Serialized_Execution_Time_s  : 4615.626
Mean_Query_Execution_Time_s        : 0.0648498890044117
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71174

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3266370
Mean_Predicate_Execution_Time_Ms   : 63.90362718628947
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 503.1579843913974
Total_Serialized_Execution_Time_s  : 3266.37
Mean_Query_Execution_Time_s        : 0.0639036271862894
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 191.0
Number_of_Predicates               : 51114

Release                            : v2.61.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4756186
Mean_Predicate_Execution_Time_Ms   : 66.62911337433282
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 451.0173047967091
Total_Serialized_Execution_Time_s  : 4756.186
Mean_Query_Execution_Time_s        : 0.0666291133743328
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 208.0
Number_of_Predicates               : 71383

Release                            : v2.61.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2784651
Mean_Predicate_Execution_Time_Ms   : 54.388777124553215
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 610.0917903271135
Total_Serialized_Execution_Time_s  : 2784.651
Mean_Query_Execution_Time_s        : 0.0543887771245532
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 142.0
Number_of_Predicates               : 51199

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2655267
Mean_Predicate_Execution_Time_Ms   : 51.8738546896673
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 558.1246726024739
Total_Serialized_Execution_Time_s  : 2655.267
Mean_Query_Execution_Time_s        : 0.0518738546896673
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 138.0
Number_of_Predicates               : 51187

Release                            : v2.62.0
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4355006
Mean_Predicate_Execution_Time_Ms   : 61.04492507814581
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 537.0863746976181
Total_Serialized_Execution_Time_s  : 4355.006
Mean_Query_Execution_Time_s        : 0.0610449250781458
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 165.0
Number_of_Predicates               : 71341

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4958885
Mean_Predicate_Execution_Time_Ms   : 69.36085545640194
Median_Predicate_Execution_Time_Ms : 1.0
Standard_Deviation_Ms              : 468.2069608070895
Total_Serialized_Execution_Time_s  : 4958.885
Mean_Query_Execution_Time_s        : 0.0693608554564019
Median_Predicate_Execution_Time_s  : 0.001
Percentile95_Ms                    : 218.0
Number_of_Predicates               : 71494

Release                            : v2.62.0
Platform                           : x86-windows
Language                           : c
Total_Serialized_Execution_Time_Ms : 3809287
Mean_Predicate_Execution_Time_Ms   : 74.47432012356057
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 607.469703694893
Total_Serialized_Execution_Time_s  : 3809.287
Mean_Query_Execution_Time_s        : 0.0744743201235605
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 196.0
Number_of_Predicates               : 51149

Release                            : 1154
Platform                           : x86-linux
Language                           : c
Total_Serialized_Execution_Time_Ms : 2371508
Mean_Predicate_Execution_Time_Ms   : 42.80159546627682
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 454.2146002474902
Total_Serialized_Execution_Time_s  : 2371.508
Mean_Query_Execution_Time_s        : 0.0428015954662768
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 121.0
Number_of_Predicates               : 55407

Release                            : 1154
Platform                           : x86-linux
Language                           : cpp
Total_Serialized_Execution_Time_Ms : 4374957
Mean_Predicate_Execution_Time_Ms   : 56.72627197759452
Median_Predicate_Execution_Time_Ms : 0.0
Standard_Deviation_Ms              : 503.02056108202953
Total_Serialized_Execution_Time_s  : 4374.957
Mean_Query_Execution_Time_s        : 0.0567262719775945
Median_Predicate_Execution_Time_s  : 0.0
Percentile95_Ms                    : 154.0
Number_of_Predicates               : 77124

🏁 Below are the slowest predicates for the last 2 releases vs this PR. 


Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 28287

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 29311

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 33680

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 31340

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 39979

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 23074

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : FunctionEquivalence::typeSig/1#194ac728
Execution_Time_Ms : 24488

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : cert-default
Predicate         : IncompatibleFunctionDeclaration::interestedInFunctions/4#95575433
Execution_Time_Ms : 26535

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 35596

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : VirtualDispatchPrototype::VirtualDispatch::cannotInheritHelper/4#7c75bd87
Execution_Time_Ms : 27766

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : autosar-default
Predicate         : Dependency::dependsOnTransitive/2#cbda84a0
Execution_Time_Ms : 26611

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : cpp
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 18257

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 25356

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Class::Class.getALinkTarget/0#dispred#29b2b38a#bf_Class::Class.getALinkTarget/0#dispred#29b2b38a#bf__#shared
Execution_Time_Ms : 25854

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 31549

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 36107

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-windows
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 32647

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 35486

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CheckedException::CheckedException#b0aa5ec8
Execution_Time_Ms : 27027

Release           : v2.62.0
Run               : 2026-07-27_15-36-06
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : Macro::MacroInvocation.getAnAffectedElement/0#dispred#d1462297_10#join_rhs
Execution_Time_Ms : 40850

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 22956

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : AlertReporting::MacroUnwrapper<Expr::Expr>::getAMacroInvocation/1#942dfbb7
Execution_Time_Ms : 23396

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : cpp
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#0b6a13dd#cpe#1236
Execution_Time_Ms : 25731

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : OutOfBounds::OOB::libraryFunctionNameParamTableSimpleString/5#6de8614f#cpe#1236
Execution_Time_Ms : 29682

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : HoldsForAllCopies::HoldsForAllCopies<DeadCode::DeadOperationInstance,Expr::Expr>::RelevantElement#acaf8a9e
Execution_Time_Ms : 27942

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : AlertReporting::MacroUnwrapper<Expr::Expr>::getAMacroInvocation/1#942dfbb7
Execution_Time_Ms : 25960

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : CharacterOutsideTheLanguageStandardBasicSourceCharacterSetUsedInTheSourceCode::getUniversalCharacterName/1#36dbaa42
Execution_Time_Ms : 21530

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : cpp
Suite             : autosar-default
Predicate         : SmartPointers::localExprFlow/2#e8a2b02b
Execution_Time_Ms : 44840

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : _Macro::Macro.getName/0#dispred#e28b3699_Preprocessor::PreprocessorBranchDirective#bcd2bde4#b_Prepro__#antijoin_rhs
Execution_Time_Ms : 29970

Release           : 1154
Run               : 2026-09-24_11-32-29
Platform          : x86-linux
Language          : c
Suite             : misra-default
Predicate         : QualifiedName::getUserTypeNameWithoutArgs/1#8cfc98e9
Execution_Time_Ms : 20491

@mbaluda
Update dataflow library
f549f7a 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@knewbury01 knewbury01 Awaiting requested review from knewbury01
@MichaelRFairhurst MichaelRFairhurst Awaiting requested review from MichaelRFairhurst

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbaluda @MichaelRFairhurst