Repository navigation
Conversation
…ession.target hyprland-session.target is ordered before graphical-session.target and dms.service after it, so add-wants created an ordering cycle and dms never autostarted.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3465
On Hyprland, dankinstall ran
systemctl --user add-wants hyprland-session.target dms.hyprland-session.targetisBefore=graphical-session.targetanddms.serviceisAfter=graphical-session.target, and systemd orders a target after the units it wants. That closes a cycle:dms.service/start after graphical-session.target/verify-active after hyprland-session.target/start after dms.servicesystemd breaks it by dropping the start job, so dms never autostarts (
enabled, inactiveindms doctor).dms.servicealready hasWantedBy=graphical-session.target, so the Hyprland path now just runssystemctl --user enable dms.service.The test puts a fake
systemctlon PATH and checks the arguments; it fails on the old code.Users who already ran the installer keep the old symlink and need to
rm ~/.config/systemd/user/hyprland-session.target.wants/dms.serviceand re-enable. I left that out to keep this small.